linux-kernel - Re: [PATCH v2 1/2] HID: HID_APPLETB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB9597160EE7E131BCC171FA39B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 10 Apr 2025 08:52:44 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
CC: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
	Kerem Karabay <kekrby@...il.com>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86



> On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@...der.be> wrote:
> 
> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
> dependency on X86, to prevent asking the user about this driver when
> configuring a kernel for a different architecture.

There are a lot of spaces before Hence. Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs.

Anyways it's Jiri's and your call regarding this change.
> 
> Fixes: 8e9b9152cfbdc2a9 ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> This is v2 of "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
> X86".
> 
> v2:
>  - Split in two patches,
>  - Correct Fixes.
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index a503252702b7b43c..119e5190a2df786e 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -163,6 +163,7 @@ config HID_APPLETB_KBD
>    depends on USB_HID
>    depends on BACKLIGHT_CLASS_DEVICE
>    depends on INPUT
> +    depends on X86 || COMPILE_TEST
>    select INPUT_SPARSEKMAP
>    select HID_APPLETB_BL
>    help
> --
> 2.43.0
>