linux-kernel - Re: [PATCH v3 2/3] clocksource/drivers/timer-tegra186: fix watchdog self-pinging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tthwz3i4iub2np6unc5o2jlaczi4wdv3t35m7ll3kcezhfm625@6jiehdzdtoiz>
Date: Thu, 10 Apr 2025 12:15:49 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Robert Lin <robelin@...dia.com>
Cc: daniel.lezcano@...aro.org, jonathanh@...dia.com, tglx@...utronix.de, 
	pohsuns@...dia.com, linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, 
	sumitg@...dia.com
Subject: Re: [PATCH v3 2/3] clocksource/drivers/timer-tegra186: fix watchdog
 self-pinging

On Mon, Apr 07, 2025 at 06:23:22PM +0800, Robert Lin wrote:
> From: Pohsun Su <pohsuns@...dia.com>
> 
> This change removes watchdog self-pinging behavior.
> 
> The timer irq handler is triggered due to the 1st expiration,
> the handler disables and enables watchdog but also implicitly
> clears the expiration count so the count can only be 0 or 1.
> 
> Since this watchdog supports opened, configured, or pinged by
> systemd, We remove this behavior or the watchdog may not bark
> when systemd crashes since the 5th expiration never comes.
> 
> Signed-off-by: Pohsun Su <pohsuns@...dia.com>
> Signed-off-by: Robert Lin <robelin@...dia.com>
> ---
>  drivers/clocksource/timer-tegra186.c | 24 ------------------------
>  1 file changed, 24 deletions(-)

Yeah, in retrospect this doesn't make sense:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)