linux-kernel - Re: [PATCH v2] platform/x86: portwell-ec: Add GPIO and WDT driver for Portwell EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a0f3243-7720-4c5d-9c71-c6c18286675b@portwell.com.tw>
Date: Thu, 10 Apr 2025 19:14:39 +0800
From: jesse huang <jesse.huang@...twell.com.tw>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com,
 linus.walleij@...aro.org, wim@...ux-watchdog.org, linux@...ck-us.net,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-watchdog@...r.kernel.org,
 jay.chen@...onical.com
Subject: Re: [PATCH v2] platform/x86: portwell-ec: Add GPIO and WDT driver for
 Portwell EC

Hi Bartosz,

Thank you for the review!

On 09/04/2025 7:46 PM, Bartosz Golaszewski wrote:
> On Wed, Apr 9, 2025 at 1:26 PM Yen-Chi Huang
> <jesse.huang@...twell.com.tw> wrote:

>> +static struct gpio_chip pwec_gpio_chip = {
>> +       .label = "portwell-ec-gpio",
>> +       .get_direction = pwec_gpio_get_direction,
>> +       .direction_input = pwec_gpio_direction_input,
>> +       .direction_output = pwec_gpio_direction_output,
>> +       .get = pwec_gpio_get,
>> +       .set = pwec_gpio_set,
> 
> Please use the set_rv() variant, set() is deprecated as of v6.15-rc1.
> 

Will update to `.set_rv` callback in v3.

>> +static int __init pwec_init(void)
>> +{
> 
> I'm not an expert in x86 platform drivers but shouldn't this be
> implemented as an actual platform driver, not a hand-coded
> quasi-driver?
> 
> Bart
> 

Will update the driver to use `platform_driver` in v3.

Best regards,  
Yen-Chi