linux-kernel - Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4745bd99e28cf90581320f8ddb591f76b1c91b9.camel@mediatek.com>
Date: Fri, 11 Apr 2025 02:54:44 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"kyrie.wu@...iatek.corp-partner.google.com"
	<kyrie.wu@...iatek.corp-partner.google.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "hverkuil-cisco@...all.nl"
	<hverkuil-cisco@...all.nl>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek,
 mt8196-jpgdec compatible

On Thu, 2025-04-10 at 08:39 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
> > Add mediatek,mt8196-jpgdec compatible to binding document.
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@...iatek.com>
> 
> Usual mediatek comment - looks like copy paste of username. Please
> reach
> to your colleagues how to fix it.

Dear Krzysztof,

Do I need to change the username like that: Kyrie Wu <
kyrie.wu@...iatek.com>?

Thanks.
> 
> > ---
> >  .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8
> > ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > index e5448c60e3eb..28a9a9bfdbf8 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > @@ -14,7 +14,9 @@ description:
> > 
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8195-jpgdec
> > +    enum:
> > +      - mediatek,mt8195-jpgdec
> > +      - mediatek,mt8196-jpgdec
> 
> And devices are not compatible?

Sorry, I don't understand the question exactly. Do you mean using the
compatible string of MT8195 for both MT8195 and MT8196?

Thanks.
> 
> Best regards,
> Krzysztof
> 

Regards,
Kyrie