linux-kernel - Re: [PATCH] kunit: cs_dsp: Depend on FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c559ae66-745e-4403-9b6f-ebc8cf85d2aa@opensource.cirrus.com>
Date: Fri, 11 Apr 2025 13:39:09 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Nico Pache <npache@...hat.com>, broonie@...nel.org,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Cc: simont@...nsource.cirrus.com, ckeepax@...nsource.cirrus.com,
        brendan.higgins@...ux.dev, davidgow@...gle.com, rmoar@...gle.com,
        johannes.berg@...el.com, sj@...nel.org
Subject: Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling
 it

On 08/04/2025 10:25 am, Richard Fitzgerald wrote:
> On 19/03/2025 11:05 pm, Nico Pache wrote:
>> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
>> depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
>> depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.
>>
>> Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file 
>> download")
>> Signed-off-by: Nico Pache <npache@...hat.com>
> 
> This patch doesn't actually work and breaks kunit.py.
> 

I was working on a series to make the same fixes to another Cirrus
KUnit test. That series makes the necessary changes to all_tests.config
so I took the liberty of fixing your patch and including it in
my series.

https://lore.kernel.org/linux-kselftest/20250411123608.1676462-1-rf@opensource.cirrus.com/T/#t