linux-kernel - Re: [PATCH] null_blk: Use strscpy() instead of strscpy_pad() in null_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174437705991.412953.12819263778991723071.b4-ty@kernel.dk>
Date: Fri, 11 Apr 2025 07:10:59 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Damien Le Moal <dlemoal@...nel.org>, 
 Chaitanya Kulkarni <kch@...dia.com>, 
 Johannes Thumshirn <johannes.thumshirn@....com>, 
 Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>, 
 Zhu Yanjun <yanjun.zhu@...ux.dev>, Zheng Qixing <zhengqixing@...wei.com>, 
 Yu Kuai <yukuai3@...wei.com>, Thorsten Blum <thorsten.blum@...ux.dev>
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] null_blk: Use strscpy() instead of strscpy_pad() in
 null_add_dev()


On Thu, 10 Apr 2025 17:47:23 +0200, Thorsten Blum wrote:
> blk_mq_alloc_disk() already zero-initializes the destination buffer,
> making strscpy() sufficient for safely copying the disk's name. The
> additional NUL-padding performed by strscpy_pad() is unnecessary.
> 
> If the destination buffer has a fixed length, strscpy() automatically
> determines its size using sizeof() when the argument is omitted. This
> makes the explicit size argument unnecessary.
> 
> [...]

Applied, thanks!

[1/1] null_blk: Use strscpy() instead of strscpy_pad() in null_add_dev()
      commit: 3b607b75a345b1d808031bf1bb1038e4dac8d521

Best regards,
-- 
Jens Axboe