linux-kernel - Re: [PATCH] drm/efidrm: ensure screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734ee3ksz.fsf@minerva.mail-host-address-is-not-set>
Date: Fri, 11 Apr 2025 15:11:08 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>, Thomas Zimmermann
 <tzimmermann@...e.de>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Nathan
 Chancellor <nathan@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Nick Desaulniers
 <nick.desaulniers+lkml@...il.com>, Bill Wendling <morbo@...gle.com>,
 Justin Stitt <justinstitt@...gle.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] drm/efidrm: ensure screen_base is initialized

Arnd Bergmann <arnd@...nel.org> writes:

Hello Arnd,

> From: Arnd Bergmann <arnd@...db.de>
>
> clang points out that there is a code path that leads to undefined behavior:
>
> drivers/gpu/drm/sysfb/efidrm.c:353:11: error: variable 'screen_base' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>   353 |         else if (mem_flags & EFI_MEMORY_WB)
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add the missing initialization.
>
> Fixes: 32ae90c66fb6 ("drm/sysfb: Add efidrm for EFI displays")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

A similar patch has been proposed by Nathan already and acked by Thomas:

https://lists.freedesktop.org/archives/dri-devel/2025-April/500539.html

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat