linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: Allow stream table to have nodes with the same ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411134204.GE8423@nvidia.com>
Date: Fri, 11 Apr 2025 10:42:04 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Pranjal Shrivastava <praan@...gle.com>
Cc: Robin Murphy <robin.murphy@....com>, Nicolin Chen <nicolinc@...dia.com>,
	will@...nel.org, joro@...tes.org, jsnitsel@...hat.com,
	linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-v3: Allow stream table to have nodes with
 the same ID

On Fri, Apr 11, 2025 at 01:35:34PM +0000, Pranjal Shrivastava wrote:
> Isn't the device grouped *after* the ops->probe_device call? I see that
> the dev->iommu_group is assigned the ops->probe_device call in
> iommu_init_device.. so I guess this would still fail?

Yes you are right, we'd have to also change to setup the stream table
inside the device_group call back to validate stream table groups are
the same.

At that point it is probably trivial to just return the group already
in the stream table.

Jason