linux-kernel - Re: [PATCH V3] iomap: skip unnecessary ifs_block_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411-ermorden-sagenhaft-dea43a3c41f9@brauner>
Date: Fri, 11 Apr 2025 16:02:44 +0200
From: Christian Brauner <brauner@...nel.org>
To: djwong@...nel.org,
	hch@...radead.org,
	Gou Hao <gouhao@...ontech.com>
Cc: Christian Brauner <brauner@...nel.org>,
	gouhaojake@....com,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-xfs@...r.kernel.org,
	wangyuli@...ontech.com
Subject: Re: [PATCH V3] iomap: skip unnecessary ifs_block_is_uptodate check

On Thu, 10 Apr 2025 15:12:36 +0800, Gou Hao wrote:
> In iomap_adjust_read_range, i is either the first !uptodate block, or it
> is past last for the second loop looking for trailing uptodate blocks.
> Assuming there's no overflow (there's no combination of huge folios and
> tiny blksize) then yeah, there is no point in retesting that the same
> block pointed to by i is uptodate since we hold the folio lock so nobody
> else could have set it uptodate.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] iomap: skip unnecessary ifs_block_is_uptodate check
      https://git.kernel.org/vfs/vfs/c/8e3c15ee0d29