linux-kernel - Re: [PATCH] panic: lib: Add TAINT for FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025041158-opal-aspirin-5909@gregkh>
Date: Fri, 11 Apr 2025 16:32:36 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Petr Mladek <pmladek@...e.com>, Dmitry Vyukov <dvyukov@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] panic: lib: Add TAINT for FAULT_INJECTION

On Fri, Apr 11, 2025 at 08:53:55AM -0400, Steven Rostedt wrote:
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -176,6 +176,9 @@ bool should_fail_ex(struct fault_attr *attr, ssize_t size, int flags)
>  	if (atomic_read(&attr->times) != -1)
>  		atomic_dec_not_zero(&attr->times);
>  
> +	if (pr_notice_once("Tainting kernel with TAINT_FAULT_INJECTION\n"))
> +		add_taint(TAINT_FAULT_INJECTION, LOCKDEP_STILL_OK);

It took me a while to think that this is the proper place to put it, but
it seems reasonable enough in the end, as you only will set the flag if
a "failure" actually happens.

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>