linux-kernel - Re: [PATCH v8 12/14] platform/x86: oxpec: Follow reverse xmas convention for tt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31eabe0a-3cc6-2022-e426-dead9ab308c9@linux.intel.com>
Date: Fri, 11 Apr 2025 18:09:16 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Antheas Kapenekakis <lkml@...heas.dev>
cc: platform-driver-x86@...r.kernel.org, linux-hwmon@...r.kernel.org, 
    linux-doc@...r.kernel.org, linux-pm@...r.kernel.org, 
    Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>, 
    Jonathan Corbet <corbet@....net>, 
    Joaquin Ignacio Aramendia <samsagax@...il.com>, 
    Derek J Clark <derekjohn.clark@...il.com>, 
    Kevin Greenberg <kdgreenberg234@...tonmail.com>, 
    Joshua Tam <csinaction@...me>, Parth Menon <parthasarathymenon@...il.com>, 
    Eileen <eileen@...-netbook.com>, LKML <linux-kernel@...r.kernel.org>, 
    sre@...nel.org, linux@...ssschuh.net, Hans de Goede <hdegoede@...hat.com>, 
    mario.limonciello@....com
Subject: Re: [PATCH v8 12/14] platform/x86: oxpec: Follow reverse xmas
 convention for tt_toggle

On Sat, 22 Mar 2025, Antheas Kapenekakis wrote:

> Since the rest of the driver follows this convention, apply it to the
> tt_toggle attribute as well.
> 
> Suggested-by: Derek J. Clark <derekjohn.clark@...il.com>
> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>
> Reviewed-by: Derek J. Clark <derekjohn.clark@...il.com>
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> ---
>  drivers/platform/x86/oxpec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index 3bf2c597e9b00..0a5b33a842b24 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -275,9 +275,9 @@ static const struct dmi_system_id dmi_table[] = {
>  /* Helper functions to handle EC read/write */
>  static int read_from_ec(u8 reg, int size, long *val)
>  {
> -	int i;
> -	int ret;
>  	u8 buffer;
> +	int ret;
> +	int i;
>  
>  	if (!lock_global_acpi_lock())
>  		return -EBUSY;
> @@ -389,8 +389,8 @@ static ssize_t tt_toggle_store(struct device *dev,
>  			       struct device_attribute *attr, const char *buf,
>  			       size_t count)
>  {
> -	int rval;
>  	bool value;
> +	int rval;
>  
>  	rval = kstrtobool(buf, &value);
>  	if (rval)
> @@ -411,8 +411,8 @@ static ssize_t tt_toggle_show(struct device *dev,
>  			      struct device_attribute *attr, char *buf)
>  {
>  	int retval;
> -	u8 reg;
>  	long val;
> +	u8 reg;
>  
>  	switch (board) {
>  	case oxp_mini_amd_a07:
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.