linux-kernel - Re: [PATCH V9 01/17] rust: cpumask: Use non-atomic helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_kzO0b43s4x162Y@yury>
Date: Fri, 11 Apr 2025 11:20:27 -0400
From: Yury Norov <yury.norov@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Danilo Krummrich <dakr@...hat.com>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, linux-pm@...r.kernel.org,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Stephen Boyd <sboyd@...nel.org>, Nishanth Menon <nm@...com>,
	rust-for-linux@...r.kernel.org,
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
	Erik Schilling <erik.schilling@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Joakim Bech <joakim.bech@...aro.org>, Rob Herring <robh@...nel.org>,
	Burak Emir <bqe@...gle.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Russell King <linux@...linux.org.uk>, linux-clk@...r.kernel.org,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V9 01/17] rust: cpumask: Use non-atomic helpers

On Fri, Apr 11, 2025 at 04:25:00PM +0530, Viresh Kumar wrote:
> The cpumask Rust abstractions don't need the atomic variants of helpers
> for now. Use the non-atomic helpers instead.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  rust/helpers/cpumask.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/rust/helpers/cpumask.c b/rust/helpers/cpumask.c
> index 2d380a86c34a..ae964cddbd41 100644
> --- a/rust/helpers/cpumask.c
> +++ b/rust/helpers/cpumask.c
> @@ -2,14 +2,14 @@
>  
>  #include <linux/cpumask.h>
>  
> -void rust_helper_cpumask_set_cpu(unsigned int cpu, struct cpumask *dstp)
> +void rust_helper___cpumask_set_cpu(unsigned int cpu, struct cpumask *dstp)
>  {
> -	cpumask_set_cpu(cpu, dstp);
> +	__cpumask_set_cpu(cpu, dstp);
>  }
>  
> -void rust_helper_cpumask_clear_cpu(int cpu, struct cpumask *dstp)
> +void rust_helper___cpumask_clear_cpu(int cpu, struct cpumask *dstp)
>  {
> -	cpumask_clear_cpu(cpu, dstp);
> +	__cpumask_clear_cpu(cpu, dstp);
>  }

Please just add non-atomic helpers after atomic ones.