linux-kernel - Re: [PATCH v8 06/14] platform/x86: oxpec: Rename ec group to tt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1fbbb55-a8dd-fc46-bcd4-ce654d63612a@linux.intel.com>
Date: Fri, 11 Apr 2025 18:22:31 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Antheas Kapenekakis <lkml@...heas.dev>
cc: platform-driver-x86@...r.kernel.org, linux-hwmon@...r.kernel.org, 
    linux-doc@...r.kernel.org, linux-pm@...r.kernel.org, 
    Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>, 
    Jonathan Corbet <corbet@....net>, 
    Joaquin Ignacio Aramendia <samsagax@...il.com>, 
    Derek J Clark <derekjohn.clark@...il.com>, 
    Kevin Greenberg <kdgreenberg234@...tonmail.com>, 
    Joshua Tam <csinaction@...me>, Parth Menon <parthasarathymenon@...il.com>, 
    Eileen <eileen@...-netbook.com>, LKML <linux-kernel@...r.kernel.org>, 
    sre@...nel.org, linux@...ssschuh.net, Hans de Goede <hdegoede@...hat.com>, 
    mario.limonciello@....com
Subject: Re: [PATCH v8 06/14] platform/x86: oxpec: Rename ec group to
 tt_toggle

On Sat, 22 Mar 2025, Antheas Kapenekakis wrote:

> Currently, the EC group is used for the turbo button. However, the next
> patch in the series adds support for the LED button in X1 devices, which
> is only applicable for X1 devices. Therefore, rename it to prepare for
> adding the second group. And make it const while at it.
> 
> Reviewed-by: Derek J. Clark <derekjohn.clark@...il.com>
> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> ---
>  drivers/platform/x86/oxpec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index dc3a0871809cd..ee37070ec54fc 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -681,18 +681,18 @@ static const struct hwmon_channel_info * const oxp_platform_sensors[] = {
>  	NULL,
>  };
>  
> -static struct attribute *oxp_ec_attrs[] = {
> +static struct attribute *oxp_tt_toggle_attrs[] = {
>  	&dev_attr_tt_toggle.attr,
>  	NULL
>  };
>  
> -static struct attribute_group oxp_ec_attribute_group = {
> +static const struct attribute_group oxp_tt_toggle_attribute_group = {
>  	.is_visible = tt_toggle_is_visible,
> -	.attrs = oxp_ec_attrs,
> +	.attrs = oxp_tt_toggle_attrs,
>  };
>  
>  static const struct attribute_group *oxp_ec_groups[] = {
> -	&oxp_ec_attribute_group,
> +	&oxp_tt_toggle_attribute_group,
>  	NULL
>  };

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.