linux-kernel - Re: [PATCH v2 1/3] selftests: coredump: Properly initialize pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96bd0364-3926-4aed-ad9d-d650c16e7440@oracle.com>
Date: Fri, 11 Apr 2025 20:57:06 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Nam Cao <namcao@...utronix.de>, Christian Brauner <brauner@...nel.org>
Cc: Shuah Khan <shuah@...nel.org>, John Ogness <john.ogness@...utronix.de>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] selftests: coredump: Properly initialize pointer



On 11-04-2025 20:39, Nam Cao wrote:
>   	/* Step 4: Make sure all stack pointer values are non-zero */
> +	line = NULL;

such case it should initialize at declaration time.
better to move up char *test_dir, *line = NULL;

>   	for (i = 0; -1 != getline(&line, &line_length, file); ++i) {
>   		stack = strtoull(line, NULL, 10);
>   		ASSERT_NE(stack, 0);
>   	}


Thanks,
Alok