linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-j722s-main: Disable "serdes_wiz0" and "serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28f1e0b7-9947-43f3-9a47-f3c6ecd69b91@ti.com>
Date: Fri, 11 Apr 2025 21:22:00 +0530
From: "Kumar, Udit" <u-kumar1@...com>
To: Siddharth Vadapalli <s-vadapalli@...com>
CC: <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <rogerq@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <srk@...com>, <u-kumar1@...com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-j722s-main: Disable
 "serdes_wiz0" and "serdes_wiz1"

Hi

On 4/11/2025 7:47 PM, Siddharth Vadapalli wrote:
> On Fri, Apr 11, 2025 at 07:31:52PM +0530, Kumar, Udit wrote:
>
> Hello Udit,
>
>> On 4/8/2025 4:06 PM, Siddharth Vadapalli wrote:
>>> Since "serdes0" and "serdes1" which are the sub-nodes of "serdes_wiz0"
>>> and "serdes_wiz1" respectively, have been disabled in the SoC file already,
>>> and, given that these sub-nodes will only be enabled in a board file if the
>>> board utilizes any of the SERDES instances and the peripherals bound to
>>> them, we end up in a situation where the board file doesn't explicitly
>>> disable "serdes_wiz0" and "serdes_wiz1". As a consequence of this, the
>>> following errors show up when booting Linux:
>>>
>>>     wiz bus@...00:phy@...0000: probe with driver wiz failed with error -12
>>>     ...
>>>     wiz bus@...00:phy@...0000: probe with driver wiz failed with error -12
>>>
>>> To not only fix the above, but also, in order to follow the convention of
>>> disabling device-tree nodes in the SoC file and enabling them in the board
>>> files for those boards which require them, disable "serdes_wiz0" and
>>> "serdes_wiz1" device-tree nodes.
>>>
>>> Fixes: 628e0a0118e6 ("arm64: dts: ti: k3-j722s-main: Add SERDES and PCIe support")
>>> Cc: stable@...r.kernel.org
>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
>>> ---
>>>
>>> v1 of this patch is at:
>>> https://lore.kernel.org/r/20250408060636.3413856-3-s-vadapalli@ti.com/
>>> Changes since v1:
>>> - Added "Fixes" tag and updated commit message accordingly.
>>>
>>> Regards,
>>> Siddharth.
>>>
>>>    arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>>> index 6850f50530f1..beda9e40e931 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>>> @@ -32,6 +32,8 @@ serdes_wiz0: phy@...0000 {
>>>    		assigned-clocks = <&k3_clks 279 1>;
>>>    		assigned-clock-parents = <&k3_clks 279 5>;
>>> +		status = "disabled";
>>> +
>> Since you are disabling parent node.
>>
>> Do you still want to carry status = "disabled" in child nodes serdes0 and
>> serdes1.
> I could drop it, but then the patches will look something like:
> 1) Patch 1: Same as the first patch in this series
> 2) Patch 2: Current patch + Remove status = "disabled" within serdes0/1
> 3) Patch 3: Removed redundant status = "okay" within serdes0/1 in
>              k3-j722s-evm.dts
>
> Updated Patch 2 and the new Patch 3 mentioned above aren't necessarily a
> complete "Fix" and have other changes in addition to the "Fix". For that
> reason, the changes associated with the updated patch 2 and the new patch 3
> could be a separate series, unless you believe that they should go
> together in the current series. Please let me know.

I don't see any use case where serdes_wiz0 is enabled and serdes0 is 
disabled.

So your comment 3) is valid. you can take this clean up in other series


For now

Reviewed-by: Udit Kumar <u-kumar1@...com>



> Regards,
> Siddharth.