linux-kernel - Re: [PATCH v2 1/2] ASoC: dt-bindings: Add Cirrus Logic CS48L32 audio DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411171404.GA3431723-robh@kernel.org>
Date: Fri, 11 Apr 2025 12:14:04 -0500
From: Rob Herring <robh@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: broonie@...nel.org, krzk+dt@...nel.org, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Add Cirrus Logic CS48L32 audio
 DSP

On Thu, Apr 10, 2025 at 10:42:11AM +0100, Richard Fitzgerald wrote:
> The CS48L32 is an Audio DSP with microphone inputs and SPI
> control interface. It has a programmable DSP and a variety of
> power-efficient fixed-function audio processors, with configurable
> digital mixing and routing.
> 
> Most properties are core properties: supply regulators, gpios, clocks,
> interrupt parent and SPI interface. The custom properties define
> the configuration of the microphone inputs to match what is physically
> attached to them.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> ---
> No changes since V1.
> ---
>  .../bindings/sound/cirrus,cs48l32.yaml        | 196 ++++++++++++++++++
>  MAINTAINERS                                   |   3 +
>  include/dt-bindings/sound/cs48l32.h           |  20 ++
>  3 files changed, 219 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
>  create mode 100644 include/dt-bindings/sound/cs48l32.h
> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
> new file mode 100644
> index 000000000000..1d58d12291d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
> @@ -0,0 +1,196 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/cirrus,cs48l32.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cirrus Logic CS48L32 audio DSP.
> +
> +maintainers:
> +  - patches@...nsource.cirrus.com
> +
> +description: |
> +  The CS48L32 is a high-performance low-power audio DSP for smartphones and
> +  other portable audio devices. The CS48L32 combines a programmable Halo Core
> +  DSP with a variety of power-efficient fixed-function audio processors.
> +
> +  See also the binding headers:
> +
> +    include/dt-bindings/sound/cs48l32.yaml
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - cirrus,cs48l32
> +
> +  reg:
> +    description: SPI chip-select number.
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 25000000
> +
> +  vdd-a-supply:
> +    description: Regulator supplying VDD_A
> +
> +  vdd-d-supply:
> +    description: Regulator supplying VDD_D
> +
> +  vdd-io-supply:
> +    description: Regulator supplying VDD_IO
> +
> +  vdd-cp-supply:
> +    description: Regulator supplying VDD_CP
> +
> +  reset-gpios:
> +    description:
> +      One entry specifying the GPIO controlling /RESET.  As defined in
> +      bindings/gpio.txt.  Although optional, it is strongly recommended
> +      to use a hardware reset.

Drop 'As defined in bindings/gpio.txt'. We don't need more references to 
old docs.

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

Rob