linux-kernel - Re: [PATCH v4 2/4] ftrace: Add support for function argument to graph tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411133347.014986f9@gandalf.local.home>
Date: Fri, 11 Apr 2025 13:33:47 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bpf@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Sven Schnelle
 <svens@...ux.ibm.com>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer
 Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Guo Ren
 <guoren@...nel.org>, Donglin Peng <dolinux.peng@...il.com>, Zheng Yejian
 <zhengyejian@...weicloud.com>, Aishwarya.TCV@....com
Subject: Re: [PATCH v4 2/4] ftrace: Add support for function argument to
 graph tracer

On Fri, 11 Apr 2025 13:02:00 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 2f077d4158e5..718f6e84cc83 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -971,11 +971,10 @@ print_graph_entry_leaf(struct trace_iterator *iter,
>  
>  		if (args_size >= FTRACE_REGS_MAX_ARGS * sizeof(long)) {
>  			print_function_args(s, entry->args, ret_func);
> -			trace_seq_putc(s, ';');
> +			trace_seq_puts(s, ";\n");
>  		} else
> -			trace_seq_puts(s, "();");
> +			trace_seq_puts(s, "();\n");
>  	}
> -	trace_seq_printf(s, "\n");
>  
>  	print_graph_irq(iter, graph_ret->func, TRACE_GRAPH_RET,
>  			cpu, iter->ent->pid, flags);

I changed the patch to have print_graph_retval() simply not add a newline,
and instead just have the caller always print the newline.

I should have never let that function do that. But when it was added, there
wasn't as many options, so it didn't look so bad, so I didn't ask for that
to be changed.

-- Steve