linux-kernel - Re: [PATCHv4] platform/x86: ideapad-laptop: added support for some new buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4351bf8-d172-4194-8074-6515f514931e@oracle.com>
Date: Fri, 11 Apr 2025 10:11:47 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Gašper Nemgar <gasper.nemgar@...il.com>,
        ikepanhc@...il.com
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCHv4] platform/x86: ideapad-laptop: added support for some
 new buttons



On 11-04-2025 02:59, Gašper Nemgar wrote:
> Added entries to unsuported wmi codes in ideapad_keymap[]

typo unsuported -> unsupported

> and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
> 
> Signed-off-by: Gašper Nemgar <gasper.nemgar@...il.com>"
> ---
> Changes in v4:
>   - Changed performace button to KE_IGNORE
> Changes in v3:
>   - Minor changes
> Changes in v2:
>   - Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
>   - Added performence toggle in wmi_notify()
> Changes in v1:
>   - Added codes for buttons on laptop(performance, star, ...)
> ---
>   drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 17a09b778..72d3306ef 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
>   	/* Specific to some newer models */
>   	{ KE_KEY,	0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
>   	{ KE_KEY,	0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> +	/* Star- (User Asignable Key) */

typo Asignable -> Assignable

> +	{ KE_KEY,	0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> +	/* Eye */
> +	{ KE_KEY,	0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> +	/* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
> +	{ KE_IGNORE,	0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> +	/* shift + prtsc */
> +	{ KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> +	{ KE_KEY,   0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> +	{ KE_KEY,   0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>   
>   	{ KE_END },
>   };
> @@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
>   		dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
>   			data->integer.value);
>   
> +		/* performance button triggered by 0x3d  */

extra space after 0x3d

> +		if (data->integer.value == 0x3d) {
> +			if (priv->dytc) {
> +				platform_profile_cycle();
> +				break;
> +			}
> +		}
> +
>   		/* 0x02 FnLock, 0x03 Esc */
>   		if (data->integer.value == 0x02 || data->integer.value == 0x03)
>   			ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);


Thanks,
Alok