linux-kernel - Re: [PATCH v2 1/5] KVM: selftests: Extract guts of THP accessor to standalone sysfs helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADrL8HWum=2uJu6N23SaWHd4r4Pu96GbEqELRms_tq8gtMBbMg@mail.gmail.com>
Date: Fri, 11 Apr 2025 16:13:16 -0700
From: James Houghton <jthoughton@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: kvm@...r.kernel.org, Maxim Levitsky <mlevitsk@...hat.com>, 
	Axel Rasmussen <axelrasmussen@...gle.com>, Tejun Heo <tj@...nel.org>, 
	Johannes Weiner <hannes@...xchg.org>, mkoutny@...e.com, Yosry Ahmed <yosry.ahmed@...ux.dev>, 
	Yu Zhao <yuzhao@...gle.com>, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] KVM: selftests: Extract guts of THP accessor to
 standalone sysfs helpers

On Fri, Apr 11, 2025 at 2:12 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> On Mon, Mar 31, 2025, James Houghton wrote:
> > From: Sean Christopherson <seanjc@...gle.com>
> >
> > Extract the guts of thp_configured() and get_trans_hugepagesz() to
> > standalone helpers so that the core logic can be reused for other sysfs
> > files, e.g. to query numa_balancing.
> >
> > Opportunistically assert that the initial fscanf() read at least one byte,
> > and add a comment explaining the second call to fscanf().
> >
> > Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> > Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>
>
> Needs your SoB.  It's a bit absurd for this particular patch, but please provide
> it anyway, if only so that I can get a giggle out of the resulting chain of SoBs :-)

Ah! I meant to include it. I'll repost the v3 with David's change to
patch 3 and my SoB here. Thanks!