linux-kernel - Re: [PATCH v13 04/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c32923d60e8d67a4a3194a405b5a422e08e280c.camel@linux.ibm.com>
Date: Fri, 11 Apr 2025 15:52:37 +1000
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linuxppc-dev@...ts.ozlabs.org, x86@...nel.org, linux-mm@...ck.org,
        linux-riscv@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, pasha.tatashin@...een.com,
        sweettea-kernel@...miny.me
Subject: Re: [PATCH v13 04/11] mm/page_table_check: Reinstate address
 parameter in [__]page_table_check_pud_clear()

On Thu, 2025-03-13 at 16:10 -0700, Andrew Morton wrote:
> On Wed, 12 Feb 2025 03:13:57 +1100 Andrew Donnellan
> <ajd@...ux.ibm.com> wrote:
> 
> > This reverts commit 931c38e16499 ("mm/page_table_check: remove
> > unused
> > parameter in [__]page_table_check_pud_clear").
> > 
> > Reinstate previously unused parameters for the purpose of
> > supporting
> > powerpc platforms, as many do not encode user/kernel ownership of
> > the
> > page in the pte, but instead in the address of the access.
> 
> My x86-64 allmodconfig exploded.
> 
> ./arch/x86/include/asm/pgtable.h: In function 'pudp_establish':
> ./arch/x86/include/asm/pgtable.h:1443:46: error: passing argument 2
> of 'page_table_check_pud_set' makes integer from pointer without a
> cast [-Werror=int-conversion]
>  1443 |         page_table_check_pud_set(vma->vm_mm, pudp, pud);
>       |                                              ^~~~
>       |                                              |
>       |                                              pud_t *
> 
> 
> 
> #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
> static inline pud_t pudp_establish(struct vm_area_struct *vma,
>                 unsigned long address, pud_t *pudp, pud_t pud)
> {
> 	page_table_check_pud_set(vma->vm_mm, pudp, pud);
> 	...
> 

Sorry, my email filters sent this to the wrong folder for some reason
and I didn't see this. I've sent v14:

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=452247

Thanks,
-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited