linux-kernel - RE: [PATCH v2] tty: serial: samsung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03cc01dbaaaa$4dea13f0$e9be3bd0$@samsung.com>
Date: Fri, 11 Apr 2025 11:53:44 +0530
From: "Faraz Ata" <faraz.ata@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, <alim.akhtar@...sung.com>,
	<krzk+dt@...nel.org>, <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>
Cc: <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-serial@...r.kernel.org>, <rosa.pila@...sung.com>,
	<dev.tailor@...sung.com>
Subject: RE: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports

Hello Krzysztof

> Subject: Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports
> 
> On 04/04/2025 15:50, Faraz Ata wrote:
> > Exynos Auto v920 SoC supports up to 18 UART ports.
> > Hence changing the value of UART_NR to 18.
> > ---
> 
> How v2, without changelog, is even worse than v1? It goes to wrong
> direction.
> 
> Please run scripts/checkpatch.pl and fix reported warnings. After that, run
> also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some
> warnings can be ignored, especially from --strict run, but the code here looks
> like it needs a fix. Feel free to get in touch if the warning is not clear.
> 
>
Thanks for your review and sorry for the noise,
 that was not intentional, got posted by mistake, will takecare about it.
Will send another version with change-log.
> ...
> Best regards,
> Krzysztof