linux-kernel - Re: [PATCH 3/3] dt-bindings: rtc: add binding for RV8063

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411071118.6fwnmpsgm46oejeb@antoni-VivoBook-ASUSLaptop-X512FAY-K512FA>
Date: Fri, 11 Apr 2025 09:11:50 +0200
From: Antoni Pokusinski <apokusinski01@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: alexandre.belloni@...tlin.com, krzk+dt@...nel.org, conor+dt@...nel.org,
	alexander.stein@...tq-group.com, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: rtc: add binding for RV8063

On Thu, Apr 10, 2025 at 04:13:51PM -0500, Rob Herring wrote:
> On Mon, Apr 07, 2025 at 09:35:21PM +0200, Antoni Pokusinski wrote:
> > Microcrystal RV8063 is a real-time clock module with SPI interface.
> > 
> > Signed-off-by: Antoni Pokusinski <apokusinski01@...il.com>
> > ---
> >  .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 33 ++++++++++++++++++-
> >  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> Bindings come before users (driver).
> 
Fixed in v3 already.

Kind regards,
Antoni

> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > index 2f892f8640d1..cb31c7619d66 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  properties:
> >    compatible:
> >      enum:
> > +      - microcrystal,rv8063
> >        - microcrystal,rv8263
> >        - nxp,pcf85063
> >        - nxp,pcf85063a
> > @@ -44,7 +45,12 @@ properties:
> >  
> >    wakeup-source: true
> >  
> > +  spi-cs-high: true
> > +
> > +  spi-3wire: true
> > +
> >  allOf:
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> >    - $ref: rtc.yaml#
> >    - if:
> >        properties:
> > @@ -52,6 +58,7 @@ allOf:
> >            contains:
> >              enum:
> >                - microcrystal,rv8263
> > +              - microcrystal,rv8063
> >      then:
> >        properties:
> >          quartz-load-femtofarads: false
> > @@ -65,12 +72,23 @@ allOf:
> >        properties:
> >          quartz-load-femtofarads:
> >            const: 7000
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          not:
> > +            contains:
> > +              enum:
> > +                - microcrystal,rv8063
> > +    then:
> > +      properties:
> > +        spi-cs-high: false
> > +        spi-3wire: false
> >  
> >  required:
> >    - compatible
> >    - reg
> >  
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >  
> >  examples:
> >    - |
> > @@ -90,3 +108,16 @@ examples:
> >            };
> >          };
> >        };
> > +
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        rtc@0 {
> > +          compatible = "microcrystal,rv8063";
> > +          reg = <0>;
> > +          spi-cs-high;
> > +          spi-3wire;
> > +        };
> > +    };
> > -- 
> > 2.25.1
> >