linux-kernel - Re: [PATCH 1/1 v6.15-rc1] perf libunwind arm64: Fix missing close parens in an if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_hndlFEnn5DHjvL@google.com>
Date: Thu, 10 Apr 2025 17:51:02 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>,
	Ian Rogers <irogers@...gle.com>,
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 v6.15-rc1] perf libunwind arm64: Fix missing close
 parens in an if statement

On Wed, Apr 09, 2025 at 10:35:31AM -0300, Arnaldo Carvalho de Melo wrote:
> While testing building with libunwind (using LIBUNWIND=1) in various
> arches I noticed a problem on arm64, on an rpi5 system, a missing close
> parens in a change related to dso__data_get_fd() usage, fix it.
> 
> Fixes: 5ac22c35aa8519f1 ("perf dso: Use lock annotations to fix asan deadlock")
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: James Clark <james.clark@...aro.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Thanks for fixing this.  For some reason the build test couldn't detect
it on my system (I have libunwind-dev installed).

I'll add it to perf-tools tree.

Thanks,
Namhyung


> ---
>  tools/perf/util/unwind-libunwind-local.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> index 9fb2c1343c7fe205..0b037e7389a009f5 100644
> --- a/tools/perf/util/unwind-libunwind-local.c
> +++ b/tools/perf/util/unwind-libunwind-local.c
> @@ -371,7 +371,7 @@ static int read_unwind_spec_debug_frame(struct dso *dso,
>  	 *    has to be pointed by symsrc_filename
>  	 */
>  	if (ofs == 0) {
> -		if (dso__data_get_fd(dso, machine, &fd) {
> +		if (dso__data_get_fd(dso, machine, &fd)) {
>  			ofs = elf_section_offset(fd, ".debug_frame");
>  			dso__data_put_fd(dso);
>  		}
> -- 
> 2.48.1
>