linux-kernel - Re: [PATCH 2/4] wifi: mwifiex: let mwifiex_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411075820.GB12707@francesco-nb>
Date: Fri, 11 Apr 2025 09:58:20 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH 2/4] wifi: mwifiex: let mwifiex_init_fw() return 0 for
 success

On Thu, Apr 10, 2025 at 12:28:44PM +0200, Sascha Hauer wrote:
> mwifiex_sta_init_cmd() returns -EINPROGRESS as sucess indication when
> the init param is true. Likewise mwifiex_init_fw() returns -EINPROGRESS
> as success indication: It will either return -EINPROGRESS directly when
> in mfg_mode or the return value of mwifiex_sta_init_cmd() when in normal
> mode.
> 
> -EINPROGRESS is a leftover from times when the initialization commands
> were sent asynchronously. Since 7bff9c974e1a ("mwifiex: send firmware
> initialization commands synchronously") the return value has become
> meaningless, so change mwifiex_sta_init_cmd() and mwifiex_init_fw()
> to return 0 for success.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>