linux-kernel - Re: [PATCH v4 1/2] perf: Fujitsu: Add the Uncore MAC PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411092332.00004b73@huawei.com>
Date: Fri, 11 Apr 2025 09:23:32 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: "Koichi Okuno (Fujitsu)" <fj2767dz@...itsu.com>
CC: Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Jonathan Corbet <corbet@....net>, Catalin Marinas <catalin.marinas@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Bjorn Andersson
	<quic_bjorande@...cinc.com>, Geert Uytterhoeven <geert+renesas@...der.be>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>, Konrad Dybcio <konradybcio@...nel.org>, "Neil
 Armstrong" <neil.armstrong@...aro.org>, Arnd Bergmann <arnd@...db.de>, "
 Nícolas \"\"F. R. A. Prado\"\"" <nfraprado@...labora.com>,
	Thomas Gleixner <tglx@...utronix.de>, "Peter Zijlstra"
	<peterz@...radead.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] perf: Fujitsu: Add the Uncore MAC PMU driver

On Fri, 11 Apr 2025 02:56:59 +0000
"Koichi Okuno (Fujitsu)" <fj2767dz@...itsu.com> wrote:

> Hi, Jonathan
> 
> Sorry for the late reply.
> Also, the person in charge here has changed from Furudera to Okuno.
> 
Hi,


> > > Text identical to memory-pwrite-count
> > > which suggest two things.
> > > a) naming inconsistent.  Why is mac mentioned here and not in the name  
> > earlier.  
> > > b) This comment is perhaps wrong as I assume has something more tod owtih  
> > with  
> > >    energy estimation?  
> > 
> > We are currently checking and will reply later.  
> 
> After checking with the hardware team,
> the 'ea' events are measured at different points and may therefore 
> return different values.
> Since memory-pwrite-count and ea-memory-mac-pwrite currently return 
> the same value, they share the same description.
> However, we have defined distinct event names to accommodate potential 
> future enhancements.

As any future enhancement to make these different will also need a change
to the documentation to reflect that difference (and hence a kernel patch)
maybe it is better to not provide the second event for now?

Or is there some other subtle effect to do with groups that can be enabled
at the same time? I've forgotten how the driver works!

Jonathan