linux-kernel - Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd1329ef-05ad-4598-804e-7801ddb1025d@collabora.com>
Date: Fri, 11 Apr 2025 14:05:38 +0530
From: Vignesh Raman <vignesh.raman@...labora.com>
To: Helen Koike <koike@...lia.com>, dri-devel@...ts.freedesktop.org
Cc: daniels@...labora.com, daniel@...ishbar.org, helen.fornazier@...il.com,
 airlied@...il.com, simona.vetter@...ll.ch, robdclark@...il.com,
 guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
 valentine.burley@...labora.com, lumag@...nel.org, quic_abhinavk@...cinc.com,
 mripard@...nel.org, maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

Hi Helen,

On 10/04/25 20:10, Helen Koike wrote:
> 
> 
> On 10/04/2025 05:07, Vignesh Raman wrote:
>> Hi Helen,
>>
>> On 09/04/25 23:53, Helen Koike wrote:
>>> Hi Vignesh,
>>>
>>> Thank you for your patch.
>>>
>>> On 09/04/2025 03:15, Vignesh Raman wrote:
>>>> Add jobs to validate devicetrees and run KUnit tests.
>>>>
>>>> Pipeline link,
>>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550
>>>
>>> I see the checks are in the same stage as build, does it make sense 
>>> to create another stage? Similar to what was proposed on kci-gitlab?
>>>
>>> Also, I don't think it make sense for kunit to be in the build stage. 
>>> Maybe in software-driver? Since kunit runs on a qemu.
>>
>> We can add a `test` stage for kunit and a `static-checks` stage for 
>> devicetree validation and check patch. What do you think?
> 
> Ack on static-checks stage.

I will update it.

> 
> `test` stage confuses me, because all the other stages with driver names 
> are also tests, this is why I suggested to move to `software-driver`.
> 
> Or maybe we could just have a kunit stage for now.

Yes, we can add kunit stage. Let the `software-driver` have only vkms 
and virtio-gpu tests.

Regards,
Vignesh

> 
> Helen
> 
>>
>> Regards,
>> Vignesh
>>
>>>
>>> Helen
>>>
>>>>
>>>> Link to v1,
>>>> https://lore.kernel.org/all/20250327160117.945165-1- 
>>>> vignesh.raman@...labora.com/
>>>>
>>>> Vignesh Raman (2):
>>>>    drm/ci: Add jobs to validate devicetrees
>>>>    drm/ci: Add jobs to run KUnit tests
>>>>
>>>>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++ 
>>>> ++++
>>>>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>>>>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>>>>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>>>>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>>>>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>>>>   6 files changed, 123 insertions(+)
>>>>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>>>>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>>>>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>>>>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>>>>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>>>
>>>
>>
>