linux-kernel - Re: [PATCH 1/2] media: synopsys: hdmirx: Renamed frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a928de25-9586-4af0-b7f3-63be75cb508b@collabora.com>
Date: Fri, 11 Apr 2025 04:13:36 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Shreeya Patel <shreeya.patel@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
 <hverkuil@...all.nl>, Dingxian Wen <shawn.wen@...k-chips.com>
Cc: linux-media@...r.kernel.org, kernel@...labora.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: synopsys: hdmirx: Renamed frame_idx to
 sequence

10.04.2025 23:43, Nicolas Dufresne пишет:
> This variable is used to fill the v4l2_buffer.sequence, let's name it
> the exact same way to reduce confusion.
> 
> No functional changes.
> 
> Fixes: 7b59b132ad439 ("media: platform: synopsys: Add support for HDMI input driver")
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>
> ---
>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 3d2913de9a86c6a4e66562727388b4326365048a..f5b3f5010ede55bde28756da326a434cc9245492 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -114,7 +114,7 @@ struct hdmirx_stream {
>  	spinlock_t vbq_lock; /* to lock video buffer queue */
>  	bool stopping;
>  	wait_queue_head_t wq_stopped;
> -	u32 frame_idx;
> +	u32 sequence;
>  	u32 line_flag_int_cnt;
>  	u32 irq_stat;
>  };
> @@ -1540,7 +1540,7 @@ static int hdmirx_start_streaming(struct vb2_queue *queue, unsigned int count)
>  	int line_flag;
>  
>  	mutex_lock(&hdmirx_dev->stream_lock);
> -	stream->frame_idx = 0;
> +	stream->sequence = 0;
>  	stream->line_flag_int_cnt = 0;
>  	stream->curr_buf = NULL;
>  	stream->next_buf = NULL;
> @@ -1948,7 +1948,7 @@ static void dma_idle_int_handler(struct snps_hdmirx_dev *hdmirx_dev,
>  
>  			if (vb_done) {
>  				vb_done->vb2_buf.timestamp = ktime_get_ns();
> -				vb_done->sequence = stream->frame_idx;
> +				vb_done->sequence = stream->sequence;
>  
>  				if (bt->interlaced)
>  					vb_done->field = V4L2_FIELD_INTERLACED_TB;
> @@ -1956,8 +1956,8 @@ static void dma_idle_int_handler(struct snps_hdmirx_dev *hdmirx_dev,
>  					vb_done->field = V4L2_FIELD_NONE;
>  
>  				hdmirx_vb_done(stream, vb_done);
> -				stream->frame_idx++;
> -				if (stream->frame_idx == 30)
> +				stream->sequence++;
> +				if (stream->sequence == 30)
>  					v4l2_dbg(1, debug, v4l2_dev,
>  						 "rcv frames\n");
>  			}
> 

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>

-- 
Best regards,
Dmitry