linux-kernel - Re: [PATCH 6/6] dt-bindings: thermal: sun8i: Add A523 THS0/1 controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250411101358.03b100ba@donnerap.manchester.arm.com>
Date: Fri, 11 Apr 2025 10:13:58 +0100
From: Andre Przywara <andre.przywara@....com>
To: iuncuim <iuncuim@...il.com>
Cc: Vasily Khoruzhick <anarsoul@...il.com>, Yangtao Li
 <tiny.windzz@...il.com>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec
 <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, "Rafael J
 . Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>,
 Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
 <linux-kernel@...r.kernel.org>, Piotr Oniszczuk <piotr.oniszczuk@...il.com>
Subject: Re: [PATCH 6/6] dt-bindings: thermal: sun8i: Add A523 THS0/1
 controllers

On Fri, 11 Apr 2025 00:50:44 +0800
iuncuim <iuncuim@...il.com> wrote:

Hi Mikhail,

many thanks for sending!

This patch needs to come earlier in the series, before the .dts patches,
and I think ideally even before the driver patches.
The repo needs to be clean at any given commit, as it stands right now the
DT validation would fail if run on patch 5/6 only.

More below...

> From: Mikhail Kalashnikov <iuncuim@...il.com>
> 
> Add dt-bindings description of the thermal sensors in the A523 processor.
> 
> Signed-off-by: Mikhail Kalashnikov <iuncuim@...il.com>
> ---
>  .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml           | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> index 3e61689f6..70ac395ef 100644
> --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> @@ -24,17 +24,21 @@ properties:
>        - allwinner,sun50i-h5-ths
>        - allwinner,sun50i-h6-ths
>        - allwinner,sun50i-h616-ths
> +      - allwinner,sun55i-a523-ths0
> +      - allwinner,sun55i-a523-ths1
>  
>    clocks:
>      minItems: 1
>      items:
>        - description: Bus Clock
> +      - description: GPADC Clock

The new clock needs to come last, to preserve the order for the existing
chips.

>        - description: Module Clock
>  
>    clock-names:
>      minItems: 1
>      items:
>        - const: bus
> +      - const: gpadc

Same here, of course.

And don't you need to adjust the number of clocks in the allOf: section
below, to require exactly three clocks for the A523?

Cheers,
Andre

>        - const: mod
>  
>    reg:
> @@ -107,6 +111,7 @@ allOf:
>              enum:
>                - allwinner,sun8i-h3-ths
>                - allwinner,sun20i-d1-ths
> +              - allwinner,sun55i-a523-ths0
>  
>      then:
>        properties: