linux-kernel - Re: Re: [PATCH v10] ufs: core: Add WB buffer resize support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250411093741.1212-1-tanghuan@vivo.com>
Date: Fri, 11 Apr 2025 17:37:41 +0800
From: Huan Tang <tanghuan@...o.com>
To: bvanassche@....org
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	avri.altman@....com,
	beanhuo@...ron.com,
	ebiggers@...gle.com,
	keosung.park@...sung.com,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	linux@...ssschuh.net,
	luhongfei@...o.com,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	minwoo.im@...sung.com,
	opensource.kernel@...o.com,
	peter.wang@...iatek.com,
	quic_cang@...cinc.com,
	quic_mnaresh@...cinc.com,
	quic_nguyenb@...cinc.com,
	tanghuan@...o.com,
	viro@...iv.linux.org.uk
Subject: Re: Re: [PATCH v10] ufs: core: Add WB buffer resize support

> Please remove this attribute again. I don't think that it is useful to
> make the value of wExtendedWriteBoosterSupport available in sysfs.
> Additionally, wExtendedWriteBoosterSupport is a bitfield and hence
> exporting it directly violates the sysfs one-value-per-attribute rule.
> 
> Why "general_fail" instead of "general_failure"?
> 
> A minor comment: please remove one tab in front of "=" for the value
> assignments in the above array definition.
> 
> The formatting of the above code is not compliant with the Linux kernel 
> coding style guide. Please reformat this patch, e.g. with "git 
> clang-format HEAD^".
>
Hi bart sir,

Thank you for your reply and comments! I have modified it as follows：
https://lore.kernel.org/all/20250411092924.1116-1-tanghuan@vivo.com/

Best wishes to you !

Thanks
Huan