linux-kernel - Re: [PATCH net-next v7 07/13] net: pse-pd: Add support for budget evaluation strategies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411114311.22c869e9@kmaincent-XPS-13-7390>
Date: Fri, 11 Apr 2025 11:43:11 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Donald Hunter
 <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org, kernel@...gutronix.de,
 linux-doc@...r.kernel.org, netdev@...r.kernel.org, Liam Girdwood
 <lgirdwood@...il.com>, Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Dent Project <dentproject@...uxfoundation.org>, Mark Brown
 <broonie@...nel.org>, Kyle Swenson <kyle.swenson@....tech>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v7 07/13] net: pse-pd: Add support for budget
 evaluation strategies

On Thu, 10 Apr 2025 14:20:02 +0200
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Hi,
> 
> looks like i started to review it and forgot to send it. Sorry :)

Hello Oleksij,

Thanks for you review and the naming fixes!

> On Tue, Apr 08, 2025 at 04:32:16PM +0200, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > 
> > This patch introduces the ability to configure the PSE PI budget evaluation
> > strategies. Budget evaluation strategies is utilized by PSE controllers to
> > determine which ports to turn off first in scenarios such as power budget
> > exceedance.
> > 
> > The pis_prio_max value is used to define the maximum priority level
> > supported by the controller. Both the current priority and the maximum
> > priority are exposed to the user through the pse_ethtool_get_status call.
> > +/**
> > + * _pse_pi_enable_sw_pw_ctrl - Enable PSE PI in case of software power
> > control.
> > + *			       Assumes the PSE lock has been acquired
> > + * @pcdev: a pointer to the PSE
> > + * @id: index of the PSE control
> > + * @extack: extack for error reporting
> > + *
> > + * Return: 0 on success and failure value on error
> > + */
> > +static int _pse_pi_enable_sw_pw_ctrl(struct pse_controller_dev *pcdev, int
> > id,
> > +				     struct netlink_ext_ack *extack)
> > +{  
> 
> Is it for "admin enable" or "start power delivery"?

Power delivery. 

I will rename it to: _pse_pi_delivery_power_sw_pw_ctrl

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com