linux-kernel - Re: [PATCH] mlxbf-bootctl: use sysfs_emit_at() in secure_boot_fuse_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174436580385.2374.522905941005450478.b4-ty@linux.intel.com>
Date: Fri, 11 Apr 2025 13:03:23 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: hdegoede@...hat.com, vadimp@...dia.com, 
 David Thompson <davthompson@...dia.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxbf-bootctl: use sysfs_emit_at() in
 secure_boot_fuse_state_show()

On Mon, 07 Apr 2025 13:25:58 +0000, David Thompson wrote:

> A warning is seen when running the latest kernel on a BlueField SOC:
> [251.512704] ------------[ cut here ]------------
> [251.512711] invalid sysfs_emit: buf:0000000003aa32ae
> [251.512720] WARNING: CPU: 1 PID: 705264 at fs/sysfs/file.c:767 sysfs_emit+0xac/0xc8
> 
> The warning is triggered because the mlxbf-bootctl driver invokes
> "sysfs_emit()" with a buffer pointer that is not aligned to the
> start of the page. The driver should instead use "sysfs_emit_at()"
> to support non-zero offsets into the destination buffer.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] mlxbf-bootctl: use sysfs_emit_at() in secure_boot_fuse_state_show()
      commit: b129005ddfc0e6daf04a6d3b928a9e474f9b3918

--
 i.