linux-kernel - Re: [PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOS=1g+nzQ-vDqJHHo-AM2A4nmF46eGXNPWRN+zt8jMS0OA@mail.gmail.com>
Date: Sat, 12 Apr 2025 15:02:32 +0800
From: David Gow <davidgow@...gle.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>, 
	Shuah Khan <skhan@...uxfoundation.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

On Mon, 7 Apr 2025 at 16:58, Thomas Weißschuh
<thomas.weissschuh@...utronix.de> wrote:
>
> The default SH kunit configuration sets CONFIG_CMDLINE_OVERWRITE which
> completely disregards the cmdline passed from the bootloader/QEMU in favor
> of the builtin CONFIG_CMDLINE.
> However the kunit tool needs to pass arguments to the in-kernel kunit core,
> for filters and other runtime parameters.
>
> Enable CONFIG_CMDLINE_EXTEND instead, so kunit arguments are respected.
>
> Fixes: 8110a3cab05e ("kunit: tool: Add support for SH under QEMU")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---

Huh, that's odd.

Anyway, this makes sense as a fix: even if sh eventually decides to do
the sane thing and make this default.

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)