linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8953: Add uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc84ef26-6c33-42d0-a11f-4d6b31d8beee@lucaweiss.eu>
Date: Sat, 12 Apr 2025 10:34:33 +0200
From: Luca Weiss <luca@...aweiss.eu>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Felix Kaechele <felix@...chele.ca>
Subject: Re: [PATCH] arm64: dts: qcom: msm8953: Add uart_5

On 4/10/25 6:45 PM, Konrad Dybcio wrote:
> On 4/6/25 3:52 PM, Luca Weiss wrote:
>> From: Felix Kaechele <felix@...chele.ca>
>>
>> Add the node and pinctrl for uart_5 found on the MSM8953 SoC.
>>
>> Signed-off-by: Felix Kaechele <felix@...chele.ca>
>> [luca: Prepare patch for upstream submission]
>> Signed-off-by: Luca Weiss <luca@...aweiss.eu>
>> ---
>>   arch/arm64/boot/dts/qcom/msm8953.dtsi | 32 ++++++++++++++++++++++++++++++++
>>   1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
>> index af4c341e2533ef2cca593e0dc97003334d3fd6b7..3d6ab83cbce4696a8eb54b16fdb429e191f44637 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
>> @@ -767,6 +767,20 @@ spi_6_sleep: spi-6-sleep-state {
>>   				bias-disable;
>>   			};
>>   
>> +			uart_5_default: uart-5-default-state {
>> +				pins = "gpio16", "gpio17", "gpio18", "gpio19";
>> +				function = "blsp_uart5";
>> +				drive-strength = <16>;
> 
> This guy's strongly biased! But it looks like that's on purpose for
> these older SoCs..
> 
>> +				bias-disable;
>> +			};
>> +
>> +			uart_5_sleep: uart-5-sleep-state {
>> +				pins = "gpio16", "gpio17", "gpio18", "gpio19";
>> +				function = "gpio";
>> +				drive-strength = <2>;
>> +				bias-disable;
>> +			};
>> +
>>   			wcnss_pin_a: wcnss-active-state {
>>   
>>   				wcss-wlan2-pins {
>> @@ -1592,6 +1606,24 @@ blsp2_dma: dma-controller@...4000 {
>>   			qcom,controlled-remotely;
>>   		};
>>   
>> +		uart_5: serial@...f000 {
>> +			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
>> +			reg = <0x07aef000 0x200>;
>> +			interrupts = <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&gcc GCC_BLSP2_UART1_APPS_CLK>,
>> +				 <&gcc GCC_BLSP2_AHB_CLK>;
>> +			clock-names = "core",
>> +				      "iface";
>> +			dmas = <&blsp2_dma 0>, <&blsp2_dma 1>;
>> +			dma-names = "tx", "rx";
> 
> Matches what the computer says
> 
> It's more usual to send these together with a user, but I don't mind

This seems to be used with the out-of-tree dts
apq8053-lenovo-cd-18781y.dts

I'm just sometimes trying to reduce the out-of-tree diff of the
msm8953-mailine tree on GitHub

Regards
Luca

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> Konrad