linux-kernel - Re: [tip: x86/build] x86/boot: Drop CRC-32 checksum and the build tool that generates it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_oo3eBywzj6s8Eg@gmail.com>
Date: Sat, 12 Apr 2025 10:48:29 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Dave Hansen <dave.hansen@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
	Ard Biesheuvel <ardb@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>, x86@...nel.org
Subject: Re: [tip: x86/build] x86/boot: Drop CRC-32 checksum and the build
 tool that generates it


* Dave Hansen <dave.hansen@...el.com> wrote:

> On 4/11/25 12:33, Dave Hansen wrote:
> ...
> > The only weird thing I'm doing is booting the kernel with qemu's -kernel
> > argument.
> 
> I lied. I'm doing other weird things. I have a local script named
> "truncate" that's not the same thing as /usr/bin/truncate. Guess what
> this patch started doing:
> 
> >  quiet_cmd_image = BUILD   $@
> > -silent_redirect_image = >/dev/null
> > -cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
> > -			       $(obj)/zoffset.h $@ $($(quiet)redirect_image)
> > +      cmd_image = cp $< $@; truncate -s %4K $@; cat $(obj)/vmlinux.bin >>$@
> 
> 				 ^ right there

Oh that sucks ...

> I'm an idiot. That was a poorly named script and it cost me a kernel
> bisect and poking at the patch for an hour. <sigh>
> 
> Sorry for the noise.

I feel your pain, I too once overlaid a well-known utility with my own 
script in ~/bin/. After that incident I started adding the .sh postfix 
to my own scripts, that way there's a much lower chance of namespace 
collisions.

Thanks,

	Ingo