linux-kernel - Re: [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250412141047.4273a8b1@jic23-huawei>
Date: Sat, 12 Apr 2025 14:10:47 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Sukrut Bellary <sbellary@...libre.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Angelo Compagnucci <angelo.compagnucci@...il.com>,
 Nishanth Menon <nm@...com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Matti Vaittinen
 <mazziesaccount@...il.com>
Subject: Re: [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021

On Tue,  8 Apr 2025 06:21:18 -0700
Sukrut Bellary <sbellary@...libre.com> wrote:

> The patch series adds the support for adc102s021 and family.
> 
> The family of devices are easier to
> support since they all (no matter the resolution) seem to respond in
> 12-bits with the LSBs set to 0 for the reduced resolution devices.

This has raced against Matti's series
https://lore.kernel.org/linux-iio/cover.1744022065.git.mazziesaccount@gmail.com/
Support ROHM BD79104 ADC

With hindsight that wasn't obvious from the patch series name though
which should ideally have been
iio: adc: ti-adc128s052: Support ROHM BD79104 ADC

Please rebase on the iio testing branch on kernel.org or on top of that series.
Technically I've only applied the first 7 patches so far, but the 8th
should be a simple change from that v3.
 
Matti, you volunteered as maintainer :)  Hence please take a look at
this one.

One nice thing in there is we now have a __be16 buffer16 element that
can avoid at least one cast in patch 2.

Thanks,

Jonathan

> 
> Changes in v3:
> 	Patch 1:
>         - No changes in dt-bindings
> 
> 	Patch 2:
> 	- used be16_to_cpu() for the endian conversion.
> 	- used config index enum while setting up the adc128_config[]
> 
> - Link to v2:
> 	https://lore.kernel.org/lkml/20231022031203.632153-1-sukrut.bellary@linux.com/
> 
> Changes in v2:
> 	Patch 1:
> 	- No changes in dt-bindings
> 
> 	Patch 2:
> 	- Arranged of_device_id and spi_device_id in numeric order.
> 	- Used enum to index into adc128_config.
> 	- Reorder adc128_config in alphabetical.
> 	- Include channel resolution information.
> 	- Shift is calculated per resolution and used in scaling and
> 	raw data read.
> 
> - Link to v1: https://lore.kernel.org/all/20220701042919.18180-1-nm@ti.com/
> 
> Sukrut Bellary (2):
>   dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family
>   iio: adc: ti-adc128s052: Add lower resolution devices support
> 
>  .../bindings/iio/adc/ti,adc128s052.yaml       |   6 +
>  drivers/iio/adc/ti-adc128s052.c               | 149 +++++++++++++-----
>  2 files changed, 118 insertions(+), 37 deletions(-)
>