linux-kernel - Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mcz3dhxkjpgp2qv72dx2lttwnzdvujvnosdx5a7lkjpuj3r4iu@jevlyctotoay>
Date: Sat, 12 Apr 2025 09:17:21 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: SeongJae Park <sj@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING

* SeongJae Park <sj@...nel.org> [250411 13:47]:
> On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <Liam.Howlett@...cle.com> wrote:
> 
> > MEMORY MAPPING does not list the mmap.h trace point file, but does list
> > the mmap.c file.  Couple the trace points with the users and authors of
> > the trace points for notifications of updates.
> > 
> > Cc:Andrew Morton <akpm@...ux-foundation.org>
> > Cc:Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > Cc:Vlastimil Babka <vbabka@...e.cz>
> > Cc:Jann Horn <jannh@...gle.com>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> 
> Aced-by: SeongJae Park <sj@...nel.org>
> 
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15571,6 +15571,7 @@ L:	linux-mm@...ck.org
> >  S:	Maintained
> >  W:	http://www.linux-mm.org
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/trace/events/mmap.h
> 
> Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
well.

There is also include/linux/mmap_lock.h, which is the locking itself.
The mmap lock is used more broadly than just these files: mm/pagewalk.c
and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam