linux-kernel - Re: [PATCH] media: amphion: fix potential NULL deref in vpu_core_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23cfd97e-b520-4e9c-a193-e0fdc885e299@web.de>
Date: Sat, 12 Apr 2025 17:15:33 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Chenyuan Yang <chenyuan0y@...il.com>, linux-media@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Charles Han
 <hanchunchao@...pur.com>, Hans Verkuil <hverkuil@...all.nl>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Ming Qian <ming.qian@....com>,
 Nicolas Dufresne <nicolas@...fresne.ca>, Shijie Qin <shijie.qin@....com>,
 Zhou Peng <eagle.zhou@....com>
Subject: Re: [PATCH] media: amphion: fix potential NULL deref in
 vpu_core_parse_dt()

> The result of memremap() may be NULL on failure, leading to a null
> dereference in the subsequent memset(). Add explicit checks after
> each memremap() call: if the firmware region fails to map, return
> immediately; if the RPC region fails, unmap the firmware window before
> returning.

* Do you propose to complete the error handling?

* Can any other summary phrase variant become more desirable accordingly?

* Please avoid duplicate source code (also for corresponding exception handling).


See also:
[PATCH] media: amphion: fix potential NULL deref in vpu_core_parse_dt
https://lore.kernel.org/all/20250407084829.5755-1-hanchunchao@inspur.com/

Regards,
Markus