linux-kernel - Re: [PATCH 0/5] gpio: aggregator: Fix Smatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bed7798-1671-4926-8d97-2e9ce34a683d@stanley.mountain>
Date: Sat, 12 Apr 2025 19:43:19 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Koichiro Den <koichiro.den@...onical.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] gpio: aggregator: Fix Smatch warnings

On Sat, Apr 12, 2025 at 11:45:08PM +0900, Koichiro Den wrote:
> On Sat, Apr 12, 2025 at 01:14:53PM GMT, Dan Carpenter wrote:
> > Fix some static checker warnings from Smatch:
> > https://github.com/error27/smatch
> > 
> > Dan Carpenter (5):
> >   gpio: aggregator: fix "_sysfs" prefix check in
> >     gpio_aggregator_make_group()
> >   gpio: aggregator: Fix gpio_aggregator_line_alloc() checking
> >   gpio: aggregator: Return an error if there are no GPIOs in
> >     gpio_aggregator_parse()
> >   gpio: aggregator: Fix error code in gpio_aggregator_activate()
> >   gpio: aggregator: Fix leak in gpio_aggregator_parse()
> > 
> >  drivers/gpio/gpio-aggregator.c | 21 ++++++++++++---------
> >  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> Thank you very much for spotting these issues. I doubt myself for having
> overlooked these.

Heh.  Don't beat yourself up.  Humans can never compete with a computer
at being nit-picky.

regards,
dan carpenter