linux-kernel - Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cb8bbf3-3f63-486a-97a0-9e1c162cef06@kernel.org>
Date: Sat, 12 Apr 2025 15:23:24 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>, Jean Delvare <jdelvare@...e.com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jonathan Corbet <corbet@....net>,
 Mario Limonciello <mario.limonciello@....com>,
 Yazen Ghannam <yazen.ghannam@....com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H . Peter Anvin" <hpa@...or.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" <linux-i2c@...r.kernel.org>,
 "open list:AMD PMC DRIVER" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR
 definition to amd_node.h

On 4/12/25 15:15, Ingo Molnar wrote:
> 
> * Mario Limonciello <superm1@...nel.org> wrote:
> 
>> SB800 is pre-Zen stuff.  It's "before my time" - I guess that's the
>> precursor to FCH being in the SoC but has the same functionality.
>>
>> So I'm thinking <asm/amd_fch.h>.
> 
> I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these
> days?
> 
> But yeah, <asm/amd_fch.h> sounds good to me too. 

OK.

> Boris?
> 
> and ... I'm sure you knew this was coming, but we should probably move
> *all* basic FCH_PM definitions into that header, such as
> SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so?

I'll double check how it's actually used against the documentation to 
see if this makes sense.

If it's only mapping a subset of registers for the PIIX4 driver use 
bringing the definition out to a header used by other drivers that might 
need a larger or smaller subset to be mapped might not make sense.