linux-kernel - Re: [PATCH] ocfs2: Simplify return statement in ocfs2_filecheck_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b37df1b1-38ed-4f2b-bf62-eee9dab64835@linux.alibaba.com>
Date: Sun, 13 Apr 2025 07:49:07 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Mark Fasheh <mark@...heh.com>,
 Joel Becker <jlbec@...lplan.org>, akpm <akpm@...ux-foundation.org>
Cc: ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Simplify return statement in
 ocfs2_filecheck_attr_store()



On 2025/4/8 18:34, Thorsten Blum wrote:
> Don't negate 'ret' and simplify the return statement.
> 
> No functional changes intended.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/filecheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2/filecheck.c
> index 1ad7106741f8..3ad7baf67658 100644
> --- a/fs/ocfs2/filecheck.c
> +++ b/fs/ocfs2/filecheck.c
> @@ -505,5 +505,5 @@ static ssize_t ocfs2_filecheck_attr_store(struct kobject *kobj,
>  		ocfs2_filecheck_handle_entry(ent, entry);
>  
>  exit:
> -	return (!ret ? count : ret);
> +	return ret ?: count;
>  }