linux-kernel - Re: [PATCH 5/6] sched/isolation: Introduce isolated task work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77f5e50c-ba52-42de-8668-e15660ba9eb3@amd.com>
Date: Sat, 12 Apr 2025 10:42:04 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Oleg Nesterov <oleg@...hat.com>, Frederic Weisbecker <frederic@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Andrew Morton
	<akpm@...ux-foundation.org>, Ingo Molnar <mingo@...hat.com>, Marcelo Tosatti
	<mtosatti@...hat.com>, Michal Hocko <mhocko@...nel.org>, Peter Zijlstra
	<peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Valentin
 Schneider <vschneid@...hat.com>, Vlastimil Babka <vbabka@...e.cz>,
	<linux-mm@...ck.org>
Subject: Re: [PATCH 5/6] sched/isolation: Introduce isolated task work

On 4/11/2025 3:55 PM, Oleg Nesterov wrote:
> 
>> +	local_irq_save(flags);
>> +	if (task_work_queued(&current->nohz_full_work)) {
>> +		ret = 0;
>> +		goto out;
>> +	}
>> +
>> +	ret = task_work_add(current, &current->nohz_full_work, TWA_RESUME);
>> +out:
>> +	local_irq_restore(flags);
>> +	return ret;
> 
> Hmm, why not
> 
> 	local_irq_save(flags);
> 	if (task_work_queued(...))
> 		ret = 0;
> 	else
> 		ret = task_work_add(...);
> 
> ?

Or use guard() sand save on flags and ret:

	guard(irqsave)();

	if (task_work_queued(...))
		return 0;

	return task_work_add(...);

-- 
Thanks and Regards,
Prateek

> 
> Oleg.
> 
>