linux-kernel - Re: [RFC 3/5] dt-bindings: power: Add binding for MediaTek MT7988 topmisc power controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174454094043.2074029.12190125666379219189.robh@kernel.org>
Date: Sun, 13 Apr 2025 05:42:20 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Wunderlich <linux@...web.de>
Cc: Vinod Koul <vkoul@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Daniel Golle <daniel@...rotopia.org>, 
 Matthias Brugger <matthias.bgg@...il.com>, linux-phy@...ts.infradead.org, 
 Chunfeng Yun <chunfeng.yun@...iatek.com>, devicetree@...r.kernel.org, 
 linux-mediatek@...ts.infradead.org, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 MandyJH Liu <mandyjh.liu@...iatek.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Frank Wunderlich <frank-w@...lic-files.de>, 
 Sam Shih <sam.shih@...iatek.com>
Subject: Re: [RFC 3/5] dt-bindings: power: Add binding for MediaTek MT7988
 topmisc power controller


On Sun, 13 Apr 2025 10:58:03 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
> 
> Topmisc is a systemcontroller used for xs-phy and ethernet on  mt7988.
> Add binding for it.
> 
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> ---
>  .../power/mediatek,power-controller.yaml      | 35 +++++++++++++------
>  1 file changed, 24 insertions(+), 11 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:28:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:39:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:40:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250413085806.8544-4-linux@fw-web.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.