linux-kernel - Re: [PATCH] net: use %ld format specifier for PTR_ERR in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fb6238636b4e20172a357a043001426e7fa34c2.camel@kernel.org>
Date: Sun, 13 Apr 2025 06:59:49 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: use %ld format specifier for PTR_ERR in pr_warn

On Sat, 2025-04-12 at 23:55 +0100, Qasim Ijaz wrote:
> PTR_ERR yields type long, so use %ld format specifier in pr_warn.
> 
> Fixes: 193510c95215 ("net: add debugfs files for showing netns refcount tracking info")
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com> 
> ---
>  net/core/net_namespace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index f47b9f10af24..a419a3aa57a6 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -1652,7 +1652,7 @@ static int __init ns_debug_init(void)
>  	if (ref_tracker_debug_dir) {
>  		ns_ref_tracker_dir = debugfs_create_dir("net_ns", ref_tracker_debug_dir);
>  		if (IS_ERR(ns_ref_tracker_dir)) {
> -			pr_warn("net: unable to create ref_tracker/net_ns directory: %d\n",
> +			pr_warn("net: unable to create ref_tracker/net_ns directory: %ld\n",
>  				PTR_ERR(ns_ref_tracker_dir));
>  			goto out;
>  		}

Thanks, that will silence a potential compiler warning. This is not
merged yet, but I'll make sure to incorporate this change in the next
version.

FWIW, I'm planning to put together a v3 that will require less
involvement with net/ code, so most of these bits will probably get
deleted anyway.

Cheers!
-- 
Jeff Layton <jlayton@...nel.org>