linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Use raw_smp_processor_id() in hwp_get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7b0b3f98f8fad9cc9559e1c4ce832387c520d7a.camel@linux.intel.com>
Date: Sun, 13 Apr 2025 07:44:56 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Xi Ruoyao <xry111@...111.site>, "Rafael J. Wysocki" <rafael@...nel.org>,
  Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>, Dave Hansen
 <dave.hansen@...ux.intel.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Use raw_smp_processor_id() in
 hwp_get_cpu_scaling()

On Sat, 2025-04-12 at 18:34 +0800, Xi Ruoyao wrote:
> Use raw_smp_processor_id() instead of plain smp_processor_id() in
> hwp_get_cpu_scaling(), otherwise we get some errors on a Lenovo
> Thinkpad
> T14P Gen 2:
> 
>     BUG: using smp_processor_id() in preemptible [00000000] code:
> swapper/0/1
>     caller is hwp_get_cpu_scaling+0x7f/0xc0
> 
> Fixes: b52aaeeadfac ("cpufreq: intel_pstate: Avoid SMP calls to get
> cpu-type")
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 4aad79d26c64..bfc20b978240 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2209,7 +2209,7 @@ static int knl_get_turbo_pstate(int cpu)
>  static int hwp_get_cpu_scaling(int cpu)
>  {
>  	if (hybrid_scaling_factor) {
> -		struct cpuinfo_x86 *c =
> &cpu_data(smp_processor_id());
> +		struct cpuinfo_x86 *c =
> &cpu_data(raw_smp_processor_id());
>  		u8 cpu_type = c->topo.intel_type;
>  
>  		/*