linux-kernel - Re: kernel/sched/syscalls.c:979:8: error: unexpected token, expected comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/sgL9Rt9c8ZGhxj@rli9-mobl>
Date: Sun, 13 Apr 2025 10:23:43 +0800
From: Philip Li <philip.li@...el.com>
To: Ingo Molnar <mingo@...nel.org>
CC: kernel test robot <lkp@...el.com>, <oe-kbuild-all@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>
Subject: Re: kernel/sched/syscalls.c:979:8: error: unexpected token, expected
 comma

+ llvm mailing list to consult

On Thu, Apr 10, 2025 at 08:56:26AM +0200, Ingo Molnar wrote:
> 
> * kernel test robot <lkp@...el.com> wrote:
> 
> > Hi Ingo,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   0af2f6be1b4281385b618cb86ad946eded089ac8
> > commit: 04746ed80bcf3130951ed4d5c1bc5b0bcabdde22 sched/syscalls: Split out kernel/sched/syscalls.c from kernel/sched/core.c
> > date:   11 months ago
> > config: mips-randconfig-r064-20250408 (https://download.01.org/0day-ci/archive/20250408/202504082254.7GLSWAbI-lkp@intel.com/config)
> > compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 92c93f5286b9ff33f27ff694d2dc33da1c07afdd)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250408/202504082254.7GLSWAbI-lkp@intel.com/reproduce)
> 
> I cannot reproduce this.

Hi Ingo, looks this problem is clang + mips specific, and it can be traced back to
early days like [1] [2] on different commits/files

	>> lib/usercopy_kunit.c:205:2: error: unexpected token, expected comma
	>> net/mctp/af_mctp.c:259:6: error: invalid operand for instruction

I add llvm mailing list to consult for this behavior, and it's possible the bot
environment is not correctly setup for this case.

BTW: the reproduce step should be below after saving the config (the steps in report is not correct)

$ mkdir build_dir && cp config build_dir/.config
$ COMPILER_INSTALL_PATH=~/temp/cross-compiler COMPILER=clang-20 ~/temp/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=mips olddefconfig
$ COMPILER_INSTALL_PATH=~/temp/cross-compiler COMPILER=clang-20 ~/temp/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/ fs/ kernel/

[1] https://lore.kernel.org/oe-kbuild-all/202201200842.QCcshg1P-lkp@intel.com/
[2] https://lore.kernel.org/oe-kbuild-all/202408200858.vCxqGpji-lkp@intel.com/

> 
> To test it, I did:
> 
>   $ wget 'https://download.01.org/0day-ci/archive/20250408/202504082254.7GLSWAbI-lkp@intel.com/config'
>   $ /bin/cp config .config
>   $ make -j102 CROSS_COMPILE=/home/mingo/gcc/cross/bin/mips64-linux- ARCH=mips kernel/sched/
> 
>   CALL    scripts/checksyscalls.sh
>   CC      kernel/sched/core.o
>   CC      kernel/sched/fair.o
>   CC      kernel/sched/build_policy.o
>   CC      kernel/sched/build_utility.o
>   AR      kernel/sched/built-in.a
> 
> Note that the config was *very* old AFAICS, from v6.10 or so, and I 
> accepted all the default .config suggestions.
> 
> Compiler used is:
> 
>   # CONFIG_CC_VERSION_TEXT="mips64-linux-gcc (GCC) 9.3.1 20200601"
> 
> Thanks,
> 
> 	Ingo
>