linux-kernel - Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4147269-6a7f-4fb7-9199-54f53be61139@gmail.com>
Date: Sun, 13 Apr 2025 17:12:24 +0200
From: Christian Schrefl <chrisi.schrefl@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
 Russ Weight <russ.weight@...ux.dev>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction
 `FwFunc`

On 13.04.25 5:07 PM, Miguel Ojeda wrote:
> On Sun, Apr 13, 2025 at 10:55 AM Christian Schrefl
> <chrisi.schrefl@...il.com> wrote:
>>
>> This causes problems on v6.13 when building for 32 bit arm (with my
>> patches), since back then `*const u8` was used in the function argument
> 
> In v6.13, the function argument used `i8` -- if it were `u8`, you
> wouldn't have had an issue, no?
Yes I've sent a new version of this section in the thread with Danilo.

I'll send it out as V3 soon.

> 
> Nowadays, in 6.13.y, everything is `u8`, so you shouldn't have a build
> error with your patches.
> 
> Cheers,
> Miguel