| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <fvjlxc2gwhhs2sv5mbag7m43s5cbmuyygjvlynpkq2jd43bqlm@pcgwo3usbdyf>
Date: Sun, 13 Apr 2025 22:46:01 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
Alyssa Rosenzweig <alyssa@...enzweig.io>, Janne Grunau <j@...nau.net>, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>, Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Mark Kettenis <mark.kettenis@...all.nl>
Subject: Re: [PATCH v3 09/13] PCI: apple: Move port PHY registers to their
own reg items
On Tue, Apr 01, 2025 at 10:17:09AM +0100, Marc Zyngier wrote:
> From: Hector Martin <marcan@...can.st>
>
> T602x PCIe cores move these registers around. Instead of hardcoding in
> another offset, let's move them into their own reg entries. This matches
> what Apple does on macOS device trees too.
>
> Maintains backwards compatibility with old DTs by using the old offsets.
>
> Note that we open code devm_platform_ioremap_resource_byname() to avoid
> error messages on older platforms with missing resources in the pcie
> node. ("pcie-apple 590000000.pcie: invalid resource (null)" on probe)
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Acked-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
> Tested-by: Janne Grunau <j@...nau.net>
> Co-developed-by: Janne Grunau <j@...nau.net>
> Signed-off-by: Janne Grunau <j@...nau.net>
> Signed-off-by: Hector Martin <marcan@...can.st>
> Signed-off-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
- Mani
> ---
> drivers/pci/controller/pcie-apple.c | 55 +++++++++++++++++++----------
> 1 file changed, 37 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index 23d9f62bd2ad4..94c49611b74df 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -39,14 +39,18 @@
> #define CORE_RC_STAT_READY BIT(0)
> #define CORE_FABRIC_STAT 0x04000
> #define CORE_FABRIC_STAT_MASK 0x001F001F
> -#define CORE_LANE_CFG(port) (0x84000 + 0x4000 * (port))
> -#define CORE_LANE_CFG_REFCLK0REQ BIT(0)
> -#define CORE_LANE_CFG_REFCLK1REQ BIT(1)
> -#define CORE_LANE_CFG_REFCLK0ACK BIT(2)
> -#define CORE_LANE_CFG_REFCLK1ACK BIT(3)
> -#define CORE_LANE_CFG_REFCLKEN (BIT(9) | BIT(10))
> -#define CORE_LANE_CTL(port) (0x84004 + 0x4000 * (port))
> -#define CORE_LANE_CTL_CFGACC BIT(15)
> +
> +#define CORE_PHY_DEFAULT_BASE(port) (0x84000 + 0x4000 * (port))
> +
> +#define PHY_LANE_CFG 0x00000
> +#define PHY_LANE_CFG_REFCLK0REQ BIT(0)
> +#define PHY_LANE_CFG_REFCLK1REQ BIT(1)
> +#define PHY_LANE_CFG_REFCLK0ACK BIT(2)
> +#define PHY_LANE_CFG_REFCLK1ACK BIT(3)
> +#define PHY_LANE_CFG_REFCLKEN (BIT(9) | BIT(10))
> +#define PHY_LANE_CFG_REFCLKCGEN (BIT(30) | BIT(31))
> +#define PHY_LANE_CTL 0x00004
> +#define PHY_LANE_CTL_CFGACC BIT(15)
>
> #define PORT_LTSSMCTL 0x00080
> #define PORT_LTSSMCTL_START BIT(0)
> @@ -146,6 +150,7 @@ struct apple_pcie_port {
> struct apple_pcie *pcie;
> struct device_node *np;
> void __iomem *base;
> + void __iomem *phy;
> struct irq_domain *domain;
> struct list_head entry;
> unsigned long *sid_map;
> @@ -476,26 +481,26 @@ static int apple_pcie_setup_refclk(struct apple_pcie *pcie,
> if (res < 0)
> return res;
>
> - rmw_set(CORE_LANE_CTL_CFGACC, pcie->base + CORE_LANE_CTL(port->idx));
> - rmw_set(CORE_LANE_CFG_REFCLK0REQ, pcie->base + CORE_LANE_CFG(port->idx));
> + rmw_set(PHY_LANE_CTL_CFGACC, port->phy + PHY_LANE_CTL);
> + rmw_set(PHY_LANE_CFG_REFCLK0REQ, port->phy + PHY_LANE_CFG);
>
> - res = readl_relaxed_poll_timeout(pcie->base + CORE_LANE_CFG(port->idx),
> - stat, stat & CORE_LANE_CFG_REFCLK0ACK,
> + res = readl_relaxed_poll_timeout(port->phy + PHY_LANE_CFG,
> + stat, stat & PHY_LANE_CFG_REFCLK0ACK,
> 100, 50000);
> if (res < 0)
> return res;
>
> - rmw_set(CORE_LANE_CFG_REFCLK1REQ, pcie->base + CORE_LANE_CFG(port->idx));
> - res = readl_relaxed_poll_timeout(pcie->base + CORE_LANE_CFG(port->idx),
> - stat, stat & CORE_LANE_CFG_REFCLK1ACK,
> + rmw_set(PHY_LANE_CFG_REFCLK1REQ, port->phy + PHY_LANE_CFG);
> + res = readl_relaxed_poll_timeout(port->phy + PHY_LANE_CFG,
> + stat, stat & PHY_LANE_CFG_REFCLK1ACK,
> 100, 50000);
>
> if (res < 0)
> return res;
>
> - rmw_clear(CORE_LANE_CTL_CFGACC, pcie->base + CORE_LANE_CTL(port->idx));
> + rmw_clear(PHY_LANE_CTL_CFGACC, port->phy + PHY_LANE_CTL);
>
> - rmw_set(CORE_LANE_CFG_REFCLKEN, pcie->base + CORE_LANE_CFG(port->idx));
> + rmw_set(PHY_LANE_CFG_REFCLKEN, port->phy + PHY_LANE_CFG);
> rmw_set(PORT_REFCLK_EN, port->base + PORT_REFCLK);
>
> return 0;
> @@ -515,6 +520,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
> struct platform_device *platform = to_platform_device(pcie->dev);
> struct apple_pcie_port *port;
> struct gpio_desc *reset;
> + struct resource *res;
> + char name[16];
> u32 stat, idx;
> int ret, i;
>
> @@ -542,10 +549,22 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
>
> raw_spin_lock_init(&port->lock);
>
> - port->base = devm_platform_ioremap_resource(platform, port->idx + 2);
> + snprintf(name, sizeof(name), "port%d", port->idx);
> + res = platform_get_resource_byname(platform, IORESOURCE_MEM, name);
> + if (!res)
> + res = platform_get_resource(platform, IORESOURCE_MEM, port->idx + 2);
> +
> + port->base = devm_ioremap_resource(&platform->dev, res);
> if (IS_ERR(port->base))
> return PTR_ERR(port->base);
>
> + snprintf(name, sizeof(name), "phy%d", port->idx);
> + res = platform_get_resource_byname(platform, IORESOURCE_MEM, name);
> + if (res)
> + port->phy = devm_ioremap_resource(&platform->dev, res);
> + else
> + port->phy = pcie->base + CORE_PHY_DEFAULT_BASE(port->idx);
> +
> rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK);
>
> /* Assert PERST# before setting up the clock */
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists