linux-kernel - Re: [PATCH] i2c: cros-ec-tunnel: defer probe if parent EC is not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yh2uau644cq22qw5wnj7cypg6wf5aoef7a7z7smbvkva56jtle@dxzs6etk7cb6>
Date: Sun, 13 Apr 2025 22:01:03 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
Cc: Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, Doug Anderson <dianders@...omium.org>, 
	Vincent Palatin <vpalatin@...omium.org>, Simon Glass <sjg@...omium.org>, Lee Jones <lee@...nel.org>, 
	Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, kernel-dev@...lia.com
Subject: Re: [PATCH] i2c: cros-ec-tunnel: defer probe if parent EC is not
 present

Hi,

On Mon, Apr 07, 2025 at 05:33:34PM -0300, Thadeu Lima de Souza Cascardo wrote:
> When i2c-cros-ec-tunnel and the EC driver are built-in, the EC parent
> device will not be found, leading to NULL pointer dereference.
> 
> That can also be reproduced by unbinding the controller driver and then
> loading i2c-cros-ec-tunnel module (or binding the device).

...

> Returning -EPROBE_DEFER will allow the device to be bound once the
> controller is bound, in the case of built-in drivers.
> 
> Fixes: 9d230c9e4f4e ("i2c: ChromeOS EC tunnel driver")
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>

merged in i2c/i2c-host-fixes.

Thanks,
Andi