linux-kernel - Re: [PATCH] PCI: fix the printed delay amount in info print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f56d8794-07a1-4040-8743-0599fb488dba@kernel.org>
Date: Sun, 13 Apr 2025 14:17:05 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Wilfred Mallawa <wilfred.opensource@...il.com>, bhelgaas@...gle.com,
 mika.westerberg@...ux.intel.com, sathyanarayanan.kuppuswamy@...ux.intel.com,
 lukas@...ner.de
Cc: alistair.francis@....com, wilfred.mallawa@....com,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, cassel@...nel.org
Subject: Re: [PATCH] PCI: fix the printed delay amount in info print

On 4/12/25 15:09, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
> 
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait
> time for slow links")
> 

Please remove the blank line here and do not wrap the Fixes tag line.
With that fixed, looks OK to me. So feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@....com>
> ---
>  drivers/pci/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
>  		delay);
>  	if (!pcie_wait_for_link_delay(dev, true, delay)) {
>  		/* Did not train, no need to wait any further */
> -		pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> +		pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
>  		return -ENOTTY;
>  	}
>  


-- 
Damien Le Moal
Western Digital Research