linux-kernel - Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_ttp0ZNHEpNhh_9@gmail.com>
Date: Sun, 13 Apr 2025 09:54:15 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Borislav Petkov <bp@...en8.de>
Cc: Mario Limonciello <superm1@...nel.org>,
	Jean Delvare <jdelvare@...e.com>,
	Andi Shyti <andi.shyti@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jonathan Corbet <corbet@....net>,
	Mario Limonciello <mario.limonciello@....com>,
	Yazen Ghannam <yazen.ghannam@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
	"H . Peter Anvin" <hpa@...or.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Hans de Goede <hdegoede@...hat.com>,
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" <linux-i2c@...r.kernel.org>,
	"open list:AMD PMC DRIVER" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR
 definition to amd_node.h


* Borislav Petkov <bp@...en8.de> wrote:

> On April 12, 2025 10:15:27 PM GMT+02:00, Ingo Molnar <mingo@...nel.org> wrote:
> >
> >* Mario Limonciello <superm1@...nel.org> wrote:
> >
> >> SB800 is pre-Zen stuff.  It's "before my time" - I guess that's the 
> >> precursor to FCH being in the SoC but has the same functionality.
> >> 
> >> So I'm thinking <asm/amd_fch.h>.
> >
> >I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these 
> >days?
> >
> >But yeah, <asm/amd_fch.h> sounds good to me too. Boris?
> 
> I was aiming more for a header which contains non-CPU defines - i.e., 
> platform. But the FCH is only one part of that platform. But let's 
> start with amd/fch.h - "amd/" subpath element would allow us to 
> trivially put other headers there too - and see where it gets us. We 
> can (and will) always refactor later if needed...

Yeah, agreed on opening the <asm/amd/> namespace for this.

Thanks,

	Ingo